Disabled container #2776
Merged
Disabled container #2776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmcgugan
requested changes
Jun 13, 2023
Member
willmcgugan
left a comment
willmcgugan
left a comment
There was a problem hiding this comment.
I think we can save a few cpu cycles here.
src/textual/widget.py
Outdated
| if ( | ||
| self.disabled | ||
| and self.app.focused is not None | ||
| and self.app.focused in self.walk_children() |
Member
There was a problem hiding this comment.
It is somewhat inefficient to walk the DOM every time something is disabled.
How about we just check if self.app.focused is disabled or has a disabled ancestor?
Member
There was a problem hiding this comment.
Yeah, that looks right to me.
Contributor
Author
There was a problem hiding this comment.
But the tests don't like it. Why does this require a screen on the stack..?
Contributor
Author
There was a problem hiding this comment.
@willmcgugan I'd say you have to check if the optimisation is worth the extra mess created to handle the cases where the disabled status is set outside the context of a running app.
Related comments: #2776 (comment)
willmcgugan
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2772 by blurring the focused widget if it is a descendant of the widget that was disabled.