in band resize protocol #5217
Merged
in band resize protocol #5217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmcgugan
requested review from
darrenburns
and removed request for
darrenburns
darrenburns
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5205
Having implemented this, it doesn't appear to make any noticeable difference.
I suspect that the for us there is no real benefit in the resize events being in-band. Previously we were handling signals and then posting events, which serialized everything anyway.
The Resize event does report the pixel size of the terminal with this protocol, which may be useful in the future when we add image support.
This also disable line-wrapping on terminals that support it. Currently only Ghostty as far as I can see. The benefit is that resizing the terminal doesn't cause the last line to wrap and scroll up. Further reducing resize jankiness.
Screen.Recording.2024-11-07.at.19.36.28.mov