tweak to select #5265
Closed
tweak to select #5265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't fix anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix the issue where the select drop-down sometimes appears blank.
I think it may be because of race condition in OptionList, where the order of messages may cause a failure to render.
This may work around it. Rather than display:none I've used visibility:hidden. This is because visibility:hidden will still go through a layout procedure and get dimensions even if it can't be seen.
Also prevented the expanded select from scrolling the container. It is not really needed as the drop-down has the constrain rules which will make it visible.
This is a workaround, until we can look at OptionList in more detail.
If anyone sees the blank Select after this has gone in, let me know!