fix(text area): fix cursor display on wrapped line #6196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `TextArea` cursor display is broken when trying to navigate a wrapped line: - Clicking a wrapped line will cause the cursor to disappear - Keyboard navigation on a wrapped line won't blink the cursor The problem is that the line cache introduced in ec0c050 doesn't properly account for wrapped lines. Fix the cache key so the 'cursor location' element is not simply based on a location in document-space. Fixes Textualize#6195
|
Since these issues depend on the cursor blink, I'm not sure it's possible to add any regression test for this? |
|
Thanks Tom. I couldn't quite manage a failing test myself. But this does seem to be the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
TextAreacursor display is broken when trying to navigate a wrapped line:The problem is that the line cache introduced in ec0c050 doesn't properly account for wrapped lines.
Fix the cache key so the 'cursor location' element is not simply based on a location in document-space.
Fixes #6195
Please review the following checklist.