Fix Windows "Alt" modifier support #6236
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add _windows_key_sequences helper to convert ESC+char into Kitty sequences - run Windows driver input through the helper, preserving Kitty-native output - cover the behavior in tests/test_windows_key_sequences.py and test_xterm_parser.py - document limitations in the FAQ and changelog Fixes Textualize#6192
mrsaraiva
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Windows terminals that don’t implement the Kitty keyboard protocol deliver Alt+key combinations as ESC followed by a character, so Textual only sees the plain key press. This PR adds a fallback path that synthesizes Kitty-style sequences in those cases, enabling Alt bindings without breaking true Kitty support added in #6207.
Fixes #6192
Testing
Added:
tests/test_windows_key_sequences.pyModified:
tests/test_xterm_parser.pyPlease review the following checklist.