Skip to content

fix(components): 135 - Isolate CSS Styles#191

Merged
HoyosJuan merged 6 commits intoThatOpen:mainfrom
HoyosJuan:135-isolate-css-styles
Nov 29, 2023
Merged

fix(components): 135 - Isolate CSS Styles#191
HoyosJuan merged 6 commits intoThatOpen:mainfrom
HoyosJuan:135-isolate-css-styles

Conversation

@HoyosJuan
Copy link
Copy Markdown
Member

Description

This PR solves issue #135 by removing most of the CSS rules applied to general HTML elements. It may be some other elements that stills get affected by the styles in the library.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following:

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Follow the Conventional Commits v1.0.0 standard for PR naming (e.g. feat(examples): add hello-world example).
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@HoyosJuan HoyosJuan merged commit 68c1d81 into ThatOpen:main Nov 29, 2023
@HoyosJuan HoyosJuan deleted the 135-isolate-css-styles branch November 29, 2023 04:02
@HoyosJuan HoyosJuan changed the title fix: 135 - Isolate CSS Styles fix(components): 135 - Isolate CSS Styles Nov 29, 2023
@HoyosJuan HoyosJuan mentioned this pull request Nov 29, 2023
2 tasks
development-ac pushed a commit to Active-Collective/ac_engine_components that referenced this pull request Aug 18, 2025
* Remove CSS rules applied to HTML elements

* Set the viewer container to position: relative

* build the library

* Set Tailwind as dev dependency

* Fixed Lock File
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant