Skip to content

fix(components): 194 - complete fix of LengthMeasurement bug while UI Disabled.#241

Merged
HoyosJuan merged 1 commit intoThatOpen:mainfrom
TristanLecallier:fix-bug-when-ui-disabled
Jan 2, 2024
Merged

fix(components): 194 - complete fix of LengthMeasurement bug while UI Disabled.#241
HoyosJuan merged 1 commit intoThatOpen:mainfrom
TristanLecallier:fix-bug-when-ui-disabled

Conversation

@TristanLecallier
Copy link
Copy Markdown
Contributor

Description

I opened this issue which was partially fixed in pr by @HoyosJuan . It seems that the modification should be applied in setupEvents function in LengthMeasurement component.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following:

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Follow the Conventional Commits v1.0.0 standard for PR naming (e.g. feat(examples): add hello-world example).
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@TristanLecallier TristanLecallier changed the title fix uimanager bug when ui disabled 194 fix uimanager bug when ui disabled Dec 29, 2023
@TristanLecallier TristanLecallier changed the title 194 fix uimanager bug when ui disabled fix(components): 194 - complete fix of LengthMeasurement bug while UI Disabled. Dec 29, 2023
@HoyosJuan HoyosJuan merged commit e54121a into ThatOpen:main Jan 2, 2024
development-ac pushed a commit to Active-Collective/ac_engine_components that referenced this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants