Skip to content

Improve Culler Visibility Through Transparent Objects #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Improve Culler Visibility Through Transparent Objects #532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/front/src/fragments/IfcStreamer/src/geometry-culler-renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,13 @@ export class GeometryCullerRenderer extends OBC.CullerRenderer {
private readonly _geometry: THREE.BufferGeometry;

private _material = new THREE.MeshBasicMaterial({
transparent: true,
transparent: false,
side: 2,
opacity: 1,
});

private _materialT = new THREE.RawShaderMaterial();

readonly onViewUpdated = new OBC.AsyncEvent<{
toLoad: { [modelID: string]: Map<number, Set<number>> };
toRemove: { [modelID: string]: Set<number> };
Expand Down Expand Up @@ -290,9 +292,10 @@ export class GeometryCullerRenderer extends OBC.CullerRenderer {
// Substitute it by fragment with same color

if (!geometry.fragment) {
const material = frag.mesh.instanceColor?.array?.[4] !== undefined && frag.mesh.instanceColor.array[4] < 0.9 ? this._materialT : this._material;
geometry.fragment = new FRAGS.Fragment(
frag.mesh.geometry,
this._material,
material,
frag.capacity,
);

Expand Down