Skip to content
This repository was archived by the owner on Jun 13, 2022. It is now read-only.

Conversation

@karx1
Copy link
Member

@karx1 karx1 commented Sep 7, 2020

This allows people to get their development environments up and running quickly and not have to track down all the dependencies to get the server up and running.

This requirements file is not meant to be completely done in any way, and modifications to this PR are welcome.

This allows people to get their development environments up and running quickly
and not have to track down all the dependencies to get the server up and running
@arthtyagi
Copy link
Member

there's technically no need of a requirements.txt file since there's already a Pipfile.
To get started quick, just do pipenv install and that's it. ( Given you first activate the pipenv environment using pipenv shell).

@arthtyagi arthtyagi merged commit 402ee86 into The-Domecode:master Sep 7, 2020
@arthtyagi
Copy link
Member

arthtyagi commented Sep 7, 2020

P.S Create a PR to the dev branch from the next time.
pip3 freeze > requirements.txt is the command you're expected to use just to you know.

@karx1
Copy link
Member Author

karx1 commented Sep 7, 2020

Alright, i'll make it to the dev branch next time. That's what I did, but first I had to actually get all the dependencies installed. Otherwise, it would have made an empty file.

@karx1
Copy link
Member Author

karx1 commented Sep 7, 2020

Another thing, pip freeze puts all of the dependencies (even dependencies of dependencies) in the requirements.txt file. This is unnecessary, because just putting the "top-level" dependencies would still install all the other ones automatically.

@karx1 karx1 deleted the requirements branch September 7, 2020 20:36
@karx1
Copy link
Member Author

karx1 commented Sep 7, 2020

@arthtyagi lol, the new requirements file that you made doesn't actually contain any of the requirements the app needs to run. It doesn't even contain django!

@arthtyagi
Copy link
Member

might've forgotten to enable the pipenv, check again.

@karx1
Copy link
Member Author

karx1 commented Sep 7, 2020

Yep, it works now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants