Skip to content

feat: add palindrome partitioning algorithm #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 25, 2020
Merged

feat: add palindrome partitioning algorithm #1319

merged 4 commits into from
Oct 25, 2020

Conversation

@KomoderHell
Copy link
Contributor

@KomoderHell KomoderHell commented Oct 17, 2020 •
edited
Loading

Description of Change

fixed: #1009

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

Panquesito7
Panquesito7 requested changes Oct 18, 2020
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well written and documented code, good work. 👍 😄
Please enable GitHub Actions in your repository of this fork in this link: https://github.com/sujaykaushik008/C-Plus-Plus/actions

@Panquesito7 Panquesito7 added enhancement New feature or request requested changes changes have been requested labels Oct 18, 2020
@KomoderHell
Copy link
Contributor Author

KomoderHell commented Oct 19, 2020

Well written and documented code, good work. 👍 😄
Please enable GitHub Actions in your repository of this fork in this link: https://github.com/sujaykaushik008/C-Plus-Plus/actions

@Panquesito7 , thank you, I have made the changes requested, please confirm that they were made properly.

Panquesito7
Panquesito7 requested changes Oct 19, 2020
View reviewed changes
Panquesito7
Panquesito7 requested changes Oct 20, 2020
View reviewed changes
Panquesito7
Panquesito7 approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; code looks neat, good work. 😄 👍

@Panquesito7 Panquesito7 added approved Approved; waiting for merge and removed requested changes changes have been requested labels Oct 21, 2020
@Panquesito7 Panquesito7 requested a review from kvedala October 21, 2020 15:34
@KomoderHell
Copy link
Contributor Author

KomoderHell commented Oct 25, 2020

@kvedala plse review the PR.

ayaankhan98
ayaankhan98 approved these changes Oct 25, 2020
View reviewed changes
Copy link
Member

@ayaankhan98 ayaankhan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SujayKaushik008 Thanks for your contribution.
LGTM

@Panquesito7 Panquesito7 merged commit 57a5dcb into TheAlgorithms:master Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ayaankhan98 ayaankhan98 ayaankhan98 approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@kvedala kvedala Awaiting requested review from kvedala

Assignees

No one assigned

Labels

approved Approved; waiting for merge enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement Palindrome Partitioning algorithm

3 participants

@KomoderHell @ayaankhan98 @Panquesito7