Skip to content

fix: quick_sort.cpp bug #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MiracleShadow wants to merge 5 commits into from
Closed

fix: quick_sort.cpp bug #1971

MiracleShadow wants to merge 5 commits into from

Conversation

@MiracleShadow
Copy link

@MiracleShadow MiracleShadow commented Aug 5, 2022 •
edited
Loading

Fix index access overflow

  • Added description of change
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

@MiracleShadow
fix quick_sort.cpp bug
796c32a 
Fix index access overflow
@CarlosZoft
Copy link
Member

CarlosZoft commented Aug 6, 2022

this is true, in the first iteration the pivot receives a memory garbage ! LGTM 🔥

CarlosZoft
CarlosZoft previously approved these changes Aug 6, 2022
View reviewed changes
@Panquesito7 Panquesito7 added the enhancement New feature or request label Aug 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2022

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Sep 14, 2022
@Panquesito7 Panquesito7 removed the stale Author has not responded to the comments for over 2 weeks label Sep 14, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2022

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Oct 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2022

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!

@github-actions github-actions bot closed this Oct 22, 2022
@Panquesito7 Panquesito7 removed the stale Author has not responded to the comments for over 2 weeks label Nov 18, 2022
@Panquesito7 Panquesito7 reopened this Nov 18, 2022
@Panquesito7
Copy link
Member

Panquesito7 commented Nov 21, 2022

Closing in favor of #2396.

@MiracleShadow MiracleShadow deleted the patch-1 branch December 7, 2022 15:38
@MiracleShadow
Copy link
Author

MiracleShadow commented Dec 7, 2022

Closing in favor of #2396.

GREAT!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@CarlosZoft CarlosZoft CarlosZoft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MiracleShadow @CarlosZoft @Panquesito7 @zhangzhuheng