Skip to content

Conversation

@TheFern2
Copy link

@TheFern2 TheFern2 commented Oct 4, 2017

No Folder/

Huffman.java

  • Fixed formatting. Indentation and tabs was missing.

Insert_delete_in_array.java

  • Fixed class name.

Conversions/

DecimalToHexaDecimal.java

  • Fixed incorrect class name from Test to DecimalToHexaDecimal.
  • Fixed string variables and missing semicolon.
  • Formatted the class correctly due to missing indentation.
  • Fixed the main method, the example was using hardcoded decimal value instead of user input.
  • Tested user input and hexadecimal output was correct.

DecimalToOctal.java

  • Fixed class name.

HexaDecimalToBinary.java

  • Fixed class name.
  • Fixed main method. Instance creation was calling the wrong class name.
  • Tested the class.

Misc/

CountTheWords.java

  • Fixed CountTheWords.java file name.

Dijkshtra.java

  • Fixed Dijkshtra.java class name.
  • Organize missing imports.

ReverseString.java

  • Fixed main method, calling wrong static class.

Class names fixed on below classes.
root_precision
TowerOfHanoiUsingRecursion
interpolationSearch
radixSort
BinaryTreeSort
AVLTree
RodCutting

Classes not running:
OctalToBinary.java
Abecedarian.java
BinaryTreeSort.java missing imports.

@TheFern2
Copy link
Author

TheFern2 commented Oct 5, 2017

Conversions/OctalToBinary.java

The algorithm was started from scratch. I've placed credit at the top to the author. It looks like whoever push the last OctalToBinary was a very bad CTRL+C, CTRL+V and the worse is it wasn't even properly tested.

I've tested against several Octal numbers and double checked with an two online conversion tools. In my opinion this algorithm is much better since it is actually doing the calculations manually rather than using built in java methods.

Sent from my Samsung SM-G955U using FastHub

@christianbender
Copy link

@kodaman2 You must resolve your conflicts then I can merge your pull request.

@TheFern2
Copy link
Author

TheFern2 commented Apr 2, 2018

It might be a good idea to cancel this PR at the time of commit there were no merge issues. I have no time to go back and undue all the fixes I've done.

@christianbender
Copy link

@kodaman2 I understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants