Skip to content

JAVA convention of PascalCase LinkList_sort -> LinkListSort #3640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2022
Merged

JAVA convention of PascalCase LinkList_sort -> LinkListSort #3640

merged 2 commits into from
Oct 24, 2022

Conversation

@debasishbsws
Copy link
Member

@debasishbsws debasishbsws commented Oct 23, 2022

Changed LinkList_sort to LinkListSort also Change the formatting

as the convention of Class name in JAVA is to use PascalCase

  • Fix a typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.

@debasishbsws
Copy link
Member Author

debasishbsws commented Oct 23, 2022

This PR is a replica of PR #3343
As I was not able to resolve the issue their

@debasishbsws
Copy link
Member Author

debasishbsws commented Oct 23, 2022

Please let me know if their any conflict now

siriak
siriak approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit d88b701 into TheAlgorithms:master Oct 24, 2022
@debasishbsws debasishbsws deleted the Naming_convention branch July 1, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@debasishbsws @siriak