sleep sort #5285
sleep sort #5285
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5285 +/- ##
============================================
+ Coverage 40.67% 40.74% +0.06%
- Complexity 2502 2509 +7
============================================
Files 519 520 +1
Lines 15447 15473 +26
Branches 2949 2953 +4
============================================
+ Hits 6283 6304 +21
- Misses 8869 8874 +5
Partials 295 295 ☔ View full report in Codecov by Sentry. |
aishuarya
force-pushed
the
feature/sleepSort
branch
8 times, most recently
from
5e02a8b to
6e789ad
Compare
aishuarya
force-pushed
the
feature/sleepSort
branch
from
6e789ad to
47f0a86
Compare
aishuarya
requested review from
BamaCharanChhandogi,
vil02 and
yanglbme
as code owners
| for (int numbers : array) { | ||
| Thread thread = new Thread(() -> { | ||
| try { | ||
| Thread.sleep(numbers); // Sleep for 'num' milliseconds |
There was a problem hiding this comment.
Do you think it is a good idea to throw IllegalArgumentException, when any of the entries is negative?
aishuarya
force-pushed
the
feature/sleepSort
branch
from
79e82d2 to
9091ad8
Compare
aishuarya
force-pushed
the
feature/sleepSort
branch
from
9091ad8 to
bf2110c
Compare
|
@vil02 Addressed you comments ! Thanks . |
vil02
left a comment
vil02
left a comment
There was a problem hiding this comment.
These are just some obvious remarks. I will provide more feedback, when I will have a bit more time.
| if (number < 0) { | ||
| throw new IllegalArgumentException("All numbers must be non-negative. Found: " + number); | ||
| } |
There was a problem hiding this comment.
This should happen, before starting any of the new threads.
| List<Integer> sortedList = Collections.synchronizedList(new ArrayList<>()); | ||
| List<Thread> threads = new ArrayList<>(); | ||
|
|
||
| for (int number : array) { |
There was a problem hiding this comment.
| for (int number : array) { | |
| for (final int number : array) { |
|
@vil02 Addressed you comments . |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution! |
|
Please reopen this pull request once you have made the required changes. If you need help, feel free to ask in our Discord server or ping one of the maintainers here. Thank you for your contribution! |
3 participants
clang-format -i --style=file path/to/your/file.java