Add iterative and recursive linear searches

[SatinWukerORIG]

I only added one searching algorithm to this directory, linear search, because I just want to make sure that the comments, format, and code style I did are correct and appropriate according to the contribution guidelines. If linear_search.nim is okay, I will continue working on other searching algorithms. @dlesnoff
And please review my code, I can't wait to make more contributions haha
Thank you!

[dlesnoff]

Thanks for this new contribution!
I made some style comments. I am going to do a second pass for the algorithm itself tonight.

[dlesnoff]

I would copy other the-algorithms repositories and name the repertory searches instead.

[ZoomRmc]

Nicely done! A few general remarks:

• Lines starting with double octothorps are doc comments. To work properly, they go under the thing, using the proper indentation.
• In the header the multiline comment is a regular one, it won't be included in the generated documentation.
• Since Nim is very overload heavy, following argument conventions (including naming and ordering) is more important than in many other languages. For searches, consider following the standard library and use key for the searched argument name. (See binarySearch)
• Explaining what the common types (like openArray) is probably excessive.
• There's a ..< for "[A, B)" (end not included) ranges.
• Use return only when you're modifying the control flow (early returns), for regular returns use expressions or an implicitly declared result (I strongly prefer the former).
  So, to return a value from a proc/block, instead of

  proc foo(a: T): T =
    return foo(bar)

  Use:

  proc foo(a: T): T =
    foo(bar)

• Consider using the module-level runnableExamples block for explaining the usage, comparison between implemented functions and general narration. This allows the per-funciton documentation to be more succinct and technical.
• For input index arguments, use Natural.

EDIT: Add indentation to the code examples.

[dlesnoff]

For input index arguments, use Natural.

Problem: the item might not be in the array, and @SatinWuker returns -1, so a Natural is not an option.
I would recommend using an Option[Natural] for the index instead.

[ZoomRmc]

For input index arguments, use Natural.

Problem: the item might not be in the array, and @SatinWuker returns -1, so a Natural is not an option. I would recommend using an Option[Natural] for the index instead.

You're correct. Seems I was talking about input arguments in general. For this specific function int is fine. Option[Natural] for both the input and output is ok too - any performance penalty is probably offset by the recursive nature of the proc.

[dlesnoff]

You are almost there.

[SatinWukerORIG]

Ahhh finally

[SatinWukerORIG]

I have double-checked, and the code works 👍
Hope this will be merged so I can move on to other tasks other than searches algorithms lol

[dlesnoff]

The code looks much better to me. I am about to merge this, but the comments do not reflect the last code changes. The writing style can be improved.

[dlesnoff]

Please run nim r .scripts/directory.nim > DIRECTORY.md and add the file to your PR.

[SatinWukerORIG]

Please run nim r .scripts/directory.nim > DIRECTORY.md and add the file to your PR.

DIRECTORY.md updated 👌

[dlesnoff]

You nailed it. Solid first contribution that will serve as reference for others.

[SatinWukerORIG]

You nailed it. Solid first contribution that will serve as reference for others.

Thank you so much for helping me from the beginning all the way to the end! This process is just like a linear search hahaha.
I really learned a lot from you guys, and I will write better-quality code and maintain this project.

[ZoomRmc]

Thank you for the contribution and sorry for a bit laborious review process.

Nim has an exceptionally high educative potential due to its uncluttered and intuitive syntax, so adhering to strict guidelines within this repository right from the get go can showcase it in a good light and help it stand out in comparison with implementations in other languages.