Skip to content

Update logical issue in decision_tree.py #13303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2025
Merged

Update logical issue in decision_tree.py #13303

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cfcff8
Update logical issue in decision_tree.py
HarshPathak310 Oct 7, 2025
205f359
Merge branch 'master' into patch-1
MaximSmolskiy Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions machine_learning/decision_tree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,14 +146,13 @@ def predict(self, x):
"""
if self.prediction is not None:
return self.prediction
elif self.left or self.right is not None:
elif self.left is not None and self.right is not None:
if x >= self.decision_boundary:
return self.right.predict(x)
else:
return self.left.predict(x)
else:
print("Error: Decision tree not yet trained")
return None
raise ValueError("Decision tree not yet trained")


class TestDecisionTree:
Expand Down Expand Up @@ -201,4 +200,4 @@ def main():
main()
import doctest

doctest.testmod(name="mean_squarred_error", verbose=True)
doctest.testmod(name="mean_squared_error", verbose=True)