Skip to content

Conversation

Mishu03
Copy link

@Mishu03 Mishu03 commented Oct 14, 2025

Add Two Randomized Algorithms

This PR adds two new randomized algorithms to the repository:

  1. Reservoir Sampling – Randomly selects k items from a stream of unknown length.
  2. Randomized QuickSort – Sorts a list using QuickSort with a randomly chosen pivot for better average-case performance.

All implementations follow Python 3.13+ standards, include type hints, docstrings, and doctests, and return results instead of printing. The code is fully compliant with repository guidelines and ready for automated testing via GitHub Actions.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my feature works
  • New and existing unit tests pass locally with my changes

@algorithms-keeper algorithms-keeper bot added the require descriptive names This PR needs descriptive function and/or variable names label Oct 14, 2025
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

import random


def miller_rabin_primality_test(n: int, k: int = 5) -> bool:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide descriptive name for the parameter: n

Please provide descriptive name for the parameter: k

T = TypeVar("T")


def reservoir_sampling(stream: Iterator[T], k: int) -> List[T]:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide descriptive name for the parameter: k

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed require descriptive names This PR needs descriptive function and/or variable names tests are failing Do not merge until tests pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant