Skip to content

Implementation of Hardy Ramanujan Algorithm in /maths #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cclauss merged 6 commits into from
Oct 19, 2019
Merged

Implementation of Hardy Ramanujan Algorithm in /maths #1355

cclauss merged 6 commits into from
Oct 19, 2019

Conversation

@alfinwilliam
Copy link
Contributor

@alfinwilliam alfinwilliam commented Oct 13, 2019 •
edited by cclauss
Loading

Fixes: #1356

@alfinwilliam alfinwilliam mentioned this pull request Oct 13, 2019
Closed
@cclauss
Copy link
Member

cclauss commented Oct 18, 2019

Please add doctests as discussed in CONTRIBUTING.md.

@alfinwilliam
Copy link
Contributor Author

alfinwilliam commented Oct 18, 2019

Added docstrings & doctests as mentioned in CONTRIBUTING.md

cclauss
cclauss requested changes Oct 18, 2019
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doctest please

maths/hardy_ramanujanalgo.py Outdated
@@ -0,0 +1,46 @@

#It's a theorem that states the number of prime factors
Copy link
Member

@cclauss cclauss Oct 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# please.

maths/hardy_ramanujanalgo.py Outdated

#It's a theorem that states the number of prime factors
# of n will approximately be log(log(n)) for most
#natural numbers n
Copy link
Member

@cclauss cclauss Oct 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# please...

maths/hardy_ramanujanalgo.py Outdated


def exactPrimeFactorCount(n) :
count = 0
Copy link
Member

@cclauss cclauss Oct 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a doctest?

maths/hardy_ramanujanalgo.py Outdated

def exactPrimeFactorCount(n) :
count = 0
if (n % 2 == 0) :
Copy link
Member

@cclauss cclauss Oct 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the ()... This is Python, not JavaScript.

maths/hardy_ramanujanalgo.py Outdated
def exactPrimeFactorCount(n) :
count = 0
if (n % 2 == 0) :
count = count + 1
Copy link
Member

@cclauss cclauss Oct 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

count += 1

maths/hardy_ramanujanalgo.py Outdated
count = 0
if (n % 2 == 0) :
count = count + 1
while (n % 2 == 0) :
Copy link
Member

@cclauss cclauss Oct 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the ()

maths/hardy_ramanujanalgo.py Outdated

i = 3

while (i <= int(math.sqrt(n))) :
Copy link
Member

@cclauss cclauss Oct 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the ()

maths/hardy_ramanujanalgo.py Outdated
i = 3

while (i <= int(math.sqrt(n))) :
if (n % i == 0) :
Copy link
Member

@cclauss cclauss Oct 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the ()

maths/hardy_ramanujanalgo.py Outdated

#this condition checks the prime
#number n is greater than 2

Copy link
Member

@cclauss cclauss Oct 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the ()

maths/hardy_ramanujanalgo.py Outdated
#number n is greater than 2

if (n > 2) :
count = count + 1
Copy link
Member

@cclauss cclauss Oct 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+=

@cclauss cclauss reopened this Oct 19, 2019
@cclauss cclauss merged commit 5c351d8 into TheAlgorithms:master Oct 19, 2019
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@alfinwilliam @stokhos
Implementation of Hardy Ramanujan Algorithm in /maths (TheAlgorithms#…
7a3f8e8 
…1355)

* Implementation of Hardy Ramanujan Algorithm

* added docstrings

* added doctests

* Run Python black on the code

* Travis CI: Upgrade to Python 3.8

* Revert to Python 3.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Merge implementation of Hardy_Ramanujan Algorithm in /maths

2 participants

@alfinwilliam @cclauss