Skip to content

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Oct 9, 2025

Pull Request Template

Description

This PR resolves new clippy lints.
Similar to:

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

Please make sure that if there is a test that takes too long to run ( > 300ms), you #[ignore] that or
try to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.

@vil02 vil02 requested a review from siriak October 9, 2025 10:05
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.32%. Comparing base (ed7a42e) to head (f0f4b8f).

Files with missing lines Patch % Lines
src/ciphers/sha3.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #926      +/-   ##
==========================================
- Coverage   95.32%   95.32%   -0.01%     
==========================================
  Files         319      319              
  Lines       20899    20895       -4     
==========================================
- Hits        19923    19919       -4     
  Misses        976      976              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vil02 vil02 force-pushed the resolve_new_clippy_warnings branch from dc79e04 to f0f4b8f Compare October 9, 2025 10:13
@vil02 vil02 marked this pull request as ready for review October 9, 2025 10:16
@vil02 vil02 requested a review from imp2002 as a code owner October 9, 2025 10:16
@vil02 vil02 mentioned this pull request Oct 14, 2025
7 tasks
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@siriak siriak merged commit cad2352 into TheAlgorithms:master Oct 15, 2025
6 checks passed
@vil02 vil02 deleted the resolve_new_clippy_warnings branch October 15, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants