Skip to content

Conversation

@AdvancedImagingUTSW
Copy link
Collaborator

This is a partial PR. I didn't want it to get too big...

  • New command line argument provided: -c --configurator to launch the configuration assistant.
  • configurator.py is the controller.
  • configurator_application_window.py is the view.
  • User can specify the number of microscopes they would like in their configuration.
  • User selects each device type, which is pulled from the __init__.py file.

TODO:

  • Still needs a user entry for them to name each microscope.
  • Currently, if they change the number of microscopes midway through the configuration, It think it will delete everything. Need a better way. For example, if they specify 2 microscopes, do a partial configuration, then specify 3, it should keep the original 2 not delete them.
  • Add two columns to the device window after they select the device type. One will be for required parameters, and the other will be for optional parameters.
  • No logic for creating YAML yet provided.

Added -c and --configurator as input arguments that are meant to launch the configuration gui
Adding the requisite controller and view elements.
Starting to work...
Now there is automatically a way to select the devices types, which are stored in __init__.

Next I am thinking we should automatically create yet another frame after they select the device type and show two columns. One for mandatory parameters, and another for optional parameters.

There are more details lurking. For some devices, like cameras, we will need to specify the number of devices. Will move to a PR so that it isn't too big.
@AdvancedImagingUTSW AdvancedImagingUTSW linked an issue Mar 19, 2024 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 8.99654% with 526 lines in your changes are missing coverage. Please review.

Project coverage is 51.06%. Comparing base (488d2b4) to head (b4e7257).
Report is 18 commits behind head on develop.

Files Patch % Lines
...c/navigate/view/configurator_application_window.py 0.00% 239 Missing ⚠️
src/navigate/controller/configurator.py 0.00% 222 Missing ⚠️
src/navigate/config/configuration_database.py 0.00% 29 Missing ⚠️
...c/navigate/view/custom_widgets/CollapsibleFrame.py 0.00% 22 Missing ⚠️
src/navigate/main.py 0.00% 6 Missing ⚠️
src/navigate/config/config.py 86.84% 5 Missing ⚠️
src/navigate/tools/main_functions.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #848      +/-   ##
===========================================
- Coverage    52.53%   51.06%   -1.47%     
===========================================
  Files          164      178      +14     
  Lines        18455    19026     +571     
===========================================
+ Hits          9695     9716      +21     
- Misses        8760     9310     +550     
Flag Coverage Δ
unittests 51.06% <8.99%> (-1.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@annie-xd-wang
Copy link
Collaborator

Do not test it now. The functions for generating configurations for microscopes are now working. They do not generate the hardware header section. I believe we should remove the header section so that the configuration does not contain redundant information. I will update the device_startup_functions later to not use the hardware header information.

@AdvancedImagingUTSW AdvancedImagingUTSW removed the request for review from annie-xd-wang May 11, 2024 14:09
@AdvancedImagingUTSW AdvancedImagingUTSW merged commit 91269ab into develop May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configuration.yaml Configurator GUI

3 participants