Update model.py #885
Merged
Update model.py #885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check to see if model has attribute signal_container before trying to reset it. Otherwise, reset the feature list... Slight refactor to hopefully make the logic more obvious. Please doublecheck.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #885 +/- ##
========================================
Coverage 51.07% 51.07%
========================================
Files 178 178
Lines 19026 19027 +1
========================================
+ Hits 9717 9718 +1
Misses 9309 9309
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
annie-xd-wang
approved these changes
May 17, 2024
Collaborator
Author
|
Difficult to test since it was a low-frequency error, but everything did seem to run as anticipated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check to see if model has attribute signal_container before trying to reset it.
Otherwise, reset the feature list...
Slight refactor to hopefully make the logic more obvious. Please doublecheck.