Extend router and remove RoutingServiceProvider

[guanguans]

Hello, I really like the features of this project. However, it requires manually registering the routing service provider. This commit solves that problem.

[andrey-helldar]

It is also worth considering that the 1st version of the project works with older versions of Laravel, starting from 7.0.

The booting method did not exist in that version.

I see two ways of events development:

1. modify your code so that it supports older versions of Laravel and release a new version as part of the 1st - 1.7.0.
2. remove support for those versions of Laravel where the booting method does not exist in the service provider and leave your code. Release the new version as a major change - 2.0.0.

Based on the situation and current time, the best solution for me is the second option, so I suggest:

1. update the code from the main branch to your project;
2. detect those Laravel versions that do not have the booting method and remove them from composer.json, .github/workflows/phpunit.xml;
3. Raise the minimum allowed version of PHP to 8.2.

[guanguans]

It is also worth considering that the 1st version of the project works with older versions of Laravel, starting from 7.0.

The booting method did not exist in that version.

I see two ways of events development:

1. modify your code so that it supports older versions of Laravel and release a new version as part of the 1st - 1.7.0.
2. remove support for those versions of Laravel where the booting method does not exist in the service provider and leave your code. Release the new version as a major change - 2.0.0.

Based on the situation and current time, the best solution for me is the second option, so I suggest:

1. update the code from the main branch to your project;
2. detect those Laravel versions that do not have the booting method and remove them from composer.json, .github/workflows/phpunit.xml;
3. Raise the minimum allowed version of PHP to 8.2.

@andrey-helldar

Sorry. I used ServiceProvider::booting() because I wanted to extend the Router as early as possible, but I didn't realize that Laravel 7 doesn't have this method. Now I using Application::booting() instead, and the tests have already passed.

Related Update

https://github.com/guanguans/laravel-route-names/blob/main/src/ServiceProvider.php#L46

    protected function extendRouter(): void
    {
-       $this->booting(function (): void {
+       $this->app->booting(function (): void {
            $this->app->extend(
                'router',
                static fn(
                    BaseRouter $router,
                    $app
                ): Router => !$router instanceof Router ? new Router($app['events'], $app) : $router
            );
        });
    }

[andrey-helldar]

Thank you!

[guanguans]

@andrey-helldar

Sorry, I just found out that there is a problem with this PR. When I updated to the latest version(1.7.0), all requests returned a 404 response. I am looking into the cause...

[andrey-helldar]

@guanguans I stopped using this project a long time ago in my applications, so I can only rely on tests.

I'm currently working on removing support for older versions of Laravel (only L10+ will be supported) and will also add Workspace to make it easier to test changes. This will be available in the coming hours.

I have also canceled the releases of versions 1.8.0 and 1.7.0.

[andrey-helldar]

@guanguans Corrected a mistake. Still this service provider is needed and it should be loaded at application startup.

For correct work it is necessary to replace the initialization of class Application. I have separated this notification into a more noticeable block on the README page.

https://github.com/TheDragonCode/laravel-route-names/releases/tag/2.0.0