Merge pull request #522 from MaoShizhong/repeat-string-test

02_repeatString: Replace regex test with built-in repeat method

Author: JoshDevHub

02_repeatString/repeatString.spec.js

@@ -24,19 +24,17 @@ describe('repeatString', () => {
     expect(repeatString('goodbye', -1)).toEqual('ERROR');
   });
   test.skip('repeats the string a random amount of times', function () {
-    /*The number is generated by using Math.random to get a value from between
-    0 to 1, when this is multiplied by 1000 and rounded down with Math.floor it 
-    equals a number between 0 to 999 (this number will change everytime you run
-    the test).*/
+    /* The number is generated by using Math.random to get a value from between
+      0 to 1, when this is multiplied by 1000 and rounded down with Math.floor it 
+      equals a number between 0 to 999 (this number will change everytime you run
+      the test).
 
-    // DO NOT use Math.floor(Math.random() * 1000) in your code, 
-    // this test generates a random number, then passes it into your code with a function parameter.
-    // If this doesn't make sense, you should go read about functions here: https://www.theodinproject.com/paths/foundations/courses/foundations/lessons/fundamentals-part-3
-    const number = Math.floor(Math.random() * 1000)
-    /*The .match(/((hey))/g).length is a regex that will count the number of heys
-    in the result, which if your function works correctly will equal the number that
-    was randomly generated. */
-    expect(repeatString('hey', number).match(/((hey))/g).length).toEqual(number);
+      DO NOT use Math.floor(Math.random() * 1000) in your code, 
+      this test generates a random number, then passes it into your code with a function parameter.
+      If this doesn't make sense, you should go read about functions here:
+      https://www.theodinproject.com/paths/foundations/courses/foundations/lessons/fundamentals-part-3 */
+    const number = Math.floor(Math.random() * 1000);
+    expect(repeatString('hey', number)).toBe('hey'.repeat(number));
   });
   test.skip('works with blank strings', () => {
     expect(repeatString('', 10)).toEqual('');

02_repeatString/solution/repeatString-solution.spec.js

@@ -24,21 +24,17 @@ describe('repeatString', () => {
     expect(repeatString('goodbye', -1)).toEqual('ERROR');
   });
   test('repeats the string a random amount of times', function () {
-    /*The number is generated by using Math.random to get a value from between
-    0 to 1, when this is multiplied by 1000 and rounded down with Math.floor it 
-    equals a number between 0 to 999 (this number will change everytime you run
-    the test).*/
+    /* The number is generated by using Math.random to get a value from between
+      0 to 1, when this is multiplied by 1000 and rounded down with Math.floor it 
+      equals a number between 0 to 999 (this number will change everytime you run
+      the test).
 
-    // DO NOT use Math.floor(Math.random() * 1000) in your code,
-    // this test generates a random number, then passes it into your code with a function parameter.
-    // If this doesn't make sense, you should go read about functions here: https://www.theodinproject.com/paths/foundations/courses/foundations/lessons/fundamentals-part-3
+      DO NOT use Math.floor(Math.random() * 1000) in your code, 
+      this test generates a random number, then passes it into your code with a function parameter.
+      If this doesn't make sense, you should go read about functions here:
+      https://www.theodinproject.com/paths/foundations/courses/foundations/lessons/fundamentals-part-3 */
     const number = Math.floor(Math.random() * 1000);
-    /*The .match(/((hey))/g).length is a regex that will count the number of heys
-    in the result, which if your function works correctly will equal the number that
-    was randomly generated. */
-    expect(repeatString('hey', number).match(/((hey))/g).length).toEqual(
-      number
-    );
+    expect(repeatString('hey', number)).toBe('hey'.repeat(number));
   });
   test('works with blank strings', () => {
     expect(repeatString('', 10)).toEqual('');