Fix/hotfixes #693
Merged
Fix/hotfixes #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added totalCostLimit and countLimit to all NSCache instances - GeneralCache: 50-150MB limit per instance based on device memory - TPPEncryptedPDFDocument: 30-80MB limit for PDF thumbnails - Added cost tracking for all cache setObject calls - Decentralized memory warning handling (each cache manages itself) - Removed redundant clearAllCaches() call from MemoryPressureMonitor - Changed to async memory clearing to avoid blocking main thread This prevents NSMallocException 'Failed to grow buffer' crashes that occur when removeAllObjects() is called on unbounded caches during memory pressure. Limits are generous and won't impact normal usage or downloads.
- PDF Text Extractor: Replaced string += concatenation with array.joined() - Added 50KB block size limit to prevent unbounded text extraction - Pre-allocate array capacity for better performance - Added size guards to break out of loops before hitting memory limits - Audiobook Logger: Added 2MB file size limit to prevent unbounded growth - Truncate log retrieval to last 1MB for large files - Use FileHandle streaming instead of loading entire files into memory These changes prevent NSMallocException '__CFStringHandleOutOfMemory' crashes that occur when string buffers grow too large during PDF parsing or log operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this do?
Why are we doing this? (w/ Notion link if applicable)
Improve user experience
How should this be tested? / Do these changes have associated tests?
Follow steps in ticket
Dependencies for merging? Releasing to production?
N/A
Does this include changes that require a new Palace build for QA?
Yes
Has the application documentation been updated for these changes?
N/A
Did someone actually run this code to verify it works?
@mauricecarrier7