Skip to content

Prevent trigger on open link to another tab #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 16, 2023
Merged

Prevent trigger on open link to another tab #6

merged 3 commits into from
Mar 16, 2023

Conversation

@gwendall
Copy link
Contributor

@gwendall gwendall commented Mar 15, 2023

No description provided.

@gwendall gwendall mentioned this pull request Mar 15, 2023
Closed
@TheSGJ TheSGJ added the invalid This doesn't seem right label Mar 16, 2023
TheSGJ
TheSGJ reviewed Mar 16, 2023
View reviewed changes
Copy link
Owner

@TheSGJ TheSGJ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for suggesting a fix for this bug, i have fixed the type errors for your code.

@TheSGJ TheSGJ added the bug Something isn't working label Mar 16, 2023
@TheSGJ TheSGJ merged commit 857b3ed into TheSGJ:master Mar 16, 2023
TheSGJ added a commit that referenced this pull request Mar 16, 2023
@TheSGJ
fix: the Loader gets triggered on navigation to link in another tab (#6…
ee479df 
…) and refactored the code a bit.
@TheSGJ TheSGJ removed the invalid This doesn't seem right label Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheSGJ TheSGJ TheSGJ left review comments

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gwendall @TheSGJ