Skip to content

Conversation

TheSecurityDev
Copy link
Owner

@TheSecurityDev TheSecurityDev commented Oct 11, 2025

Attempt at scrolling screenshots (this PR is for testing the UI previews)

@Copilot Copilot AI review requested due to automatic review settings October 11, 2025 01:27
@github-actions github-actions bot added the ui label Oct 11, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements scrolling screenshot functionality for UI testing by adding the ability to capture multiple screenshots while scrolling through content until no more changes are detected.

  • Added capture_scrollable method that takes multiple screenshots while scrolling and compares them to detect when content stops changing
  • Added helper method screenshot_with_suffix for saving screenshots with custom suffixes
  • Integrated scrolling capture into the main test flow with fallback to single screenshots

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@TheSecurityDev TheSecurityDev marked this pull request as draft October 11, 2025 01:28
@TheSecurityDev TheSecurityDev marked this pull request as ready for review October 11, 2025 02:39
@TheSecurityDev TheSecurityDev marked this pull request as draft October 11, 2025 02:40
@TheSecurityDev TheSecurityDev marked this pull request as ready for review October 11, 2025 02:56
@TheSecurityDev TheSecurityDev marked this pull request as draft October 11, 2025 23:23
@TheSecurityDev TheSecurityDev changed the title wip: Scrolling screenshots test scrolling screenshots Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant