-
Notifications
You must be signed in to change notification settings - Fork 0
test scrolling screenshots #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- the change is something we merge
- include a route or your device' dongle ID if relevant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements scrolling screenshot functionality for UI testing by adding the ability to capture multiple screenshots while scrolling through content until no more changes are detected.
- Added
capture_scrollable
method that takes multiple screenshots while scrolling and compares them to detect when content stops changing - Added helper method
screenshot_with_suffix
for saving screenshots with custom suffixes - Integrated scrolling capture into the main test flow with fallback to single screenshots
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…oesn't use xdotool
This reverts commit 41bba83.
Attempt at scrolling screenshots (this PR is for testing the UI previews)