forked from electronicarts/CnC_Generals_Zero_Hour
-
Notifications
You must be signed in to change notification settings - Fork 119
Labels
MinorSeverity: Minor < Major < Critical < BlockerSeverity: Minor < Major < Critical < BlockerPerformanceIs a performance concernIs a performance concernRefactorEdits the code with insignificant behavior changes, is never user facingEdits the code with insignificant behavior changes, is never user facing
Description
There are a couple of functions where std::vector<T> containers are copied instead of moved:
aiFollowExitProductionPath
aiFollowPath
AIStateMachine::setGoalPath
Maybe more could be found with queries such as: \(.*std::vector<.*>\s*\*
Beware that moving from const std::vector<T>* is meaningless, so this would require removing const from the function parameter at all call sites.
Metadata
Metadata
Assignees
Labels
MinorSeverity: Minor < Major < Critical < BlockerSeverity: Minor < Major < Critical < BlockerPerformanceIs a performance concernIs a performance concernRefactorEdits the code with insignificant behavior changes, is never user facingEdits the code with insignificant behavior changes, is never user facing