bugfix(object): Check whether a bike still has a rider before sniping it to prevent crashing the game #1537
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brought to my attention by @MrS-ibra
This PR fixes a crash caused by accessing the first element of an empty list. This bug happens when you use Jarmen Kell to snipe an empty bike. Normally, empty (enemy) bikes are immediately destroyed, but disabled bikes can be empty for as long as they're disabled.
Bug reproduction:
GeneralsGameCode/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Body/ActiveBody.cpp
Lines 408 to 409 in 87de0a0
PS: It probably shouldn't be possible to dismount from a disabled bike, but that's outside the scope of this PR.