bugfix(view): Prevent moving the camera with most user inputs during camera playback in Replay playback #1599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Bug
Mauller
approved these changes
Sep 20, 2025
Mauller
left a comment
Mauller
left a comment
There was a problem hiding this comment.
I have honestly never seen this happen before but it does look comical.
xezon
changed the title
…era playback in Replay playback
xezon
force-pushed
the
xezon/fix-camera-movement-during-replay-camera
branch
from
6f1c55c to
28c0d7f
Compare
Author
|
Replicated in Generals without conflicts |
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
…camera playback in Replay playback (TheSuperHackers#1599)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents moving the camera with most user inputs during camera playback in Replay playback. The possibility of this behavior was introduced with the render and logic update decoupling. When the logic step is smaller than the render update, then there is room for user input to move the camera after a
MSG_SET_REPLAY_CAMERAmessage.Numpad 5 still causes issues but it is very minor and a different problem.
Before this fix
generalszh.2025-09-18.20-33-52-39.mp4
TODO