Skip to content

bugfix(behavior): Fix hardcoded cash hack value for Black Lotus #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2025
Merged

bugfix(behavior): Fix hardcoded cash hack value for Black Lotus #1601

merged 1 commit into from
Sep 19, 2025

Conversation

@Stubbjax
Copy link

@Stubbjax Stubbjax commented Sep 19, 2025

This change allows the EffectValue defined in the SpecialAbilityUpdate module to control the amount of cash stolen by Black Lotus's Cash Hack ability as originally intended.

  Behavior = SpecialAbilityUpdate ModuleTag_13
    SpecialPowerTemplate  = SpecialAbilityBlackLotusStealCashHack
    StartAbilityRange     = 150.0
    UnpackTime            = 6730 ;animation time is 6730 (changing this will scale anim speed)
    PackTime              = 5800 ;animation time is 5800 (changing this will scale anim speed)
    PreparationTime       = 6000 ;time to complete hack once prepared (unpacked)
    EffectValue           = 1000 ;amount of cash stolen
    SpecialObject         = BinaryDataStream
    PackSound             = BlackLotusPack
    UnpackSound           = BlackLotusUnpack
    TriggerSound          = BlackLotusTrigger
    PrepSoundLoop         = BlackLotusPrepLoop
    AwardXPForTriggering  = 20
    ;SkillPointsForTriggering = ???  -- Dustin, fill me out if you want different balance values.
  End

@Stubbjax Stubbjax self-assigned this Sep 19, 2025
@Stubbjax Stubbjax added Bug Something is not working right, typically is user facing China Affects China faction Minor Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour NoRetail This fix or change is not applicable with Retail game compatibility labels Sep 19, 2025
@Stubbjax Stubbjax changed the title bugfix: Fix hardcoded cash hack value for China Lotus bugfix: Fix hardcoded cash hack value for Black Lotus Sep 19, 2025
xezon
xezon approved these changes Sep 19, 2025
View reviewed changes
Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find.

@xezon xezon mentioned this pull request Sep 19, 2025
Open
@xezon xezon changed the title bugfix: Fix hardcoded cash hack value for Black Lotus bugfix(behavior): Fix hardcoded cash hack value for Black Lotus Sep 19, 2025
@xezon xezon merged commit 1b8c7d9 into TheSuperHackers:main Sep 19, 2025
19 checks passed
@Stubbjax Stubbjax deleted the fix-hardcoded-cash-hack-value branch September 19, 2025 13:04
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Nov 10, 2025
@Stubbjax
bugfix(behavior): Fix hardcoded cash hack value for Black Lotus (TheS…
0fe1344 
…uperHackers#1601)
Skyaero42 added a commit to Skyaero42/GeneralsGameCode that referenced this pull request Nov 15, 2025
@Skyaero42
tweak: Add RETAIL_COMPATIBLE_BUG to Black Lotus cash fix
baae135 
- Follow up on TheSuperHackers#1601

With  TheSuperHackers#1601 removing the hardcoded cash gain when Black Lotus performs a successfull cash hack, the Super Lotus now gains 1.500 instead of 1.000 credits per INI configuration.

To keep in line with expectations, this fix also needs to be behind RETAIL_COMPATIBLE_BUG guards.
@Skyaero42 Skyaero42 mentioned this pull request Nov 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xezon xezon xezon approved these changes

Assignees

@Stubbjax Stubbjax

Labels

Bug Something is not working right, typically is user facing China Affects China faction Gen Relates to Generals Minor Severity: Minor < Major < Critical < Blocker NoRetail This fix or change is not applicable with Retail game compatibility ZH Relates to Zero Hour

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Stubbjax @xezon