bugfix(input): Force stop camera inputs after game end #1602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mauller
approved these changes
Sep 20, 2025
Mauller
left a comment
Mauller
left a comment
There was a problem hiding this comment.
Looks good, i have also never come across this before and it does look funny.
xezon
changed the title
xezon
force-pushed
the
xezon/fix-camera-movement-after-match-end
branch
from
4b07cf0 to
d6fbad2
Compare
Author
|
Replicated in Generals without conflicts |
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change force stops camera inputs after match end to avoid stuck camera movements in the Shell Map after a Replay playback has ended while the user did some camera movements.
While at it I also refactored some value assignments to function calls in
InGameUI::resetfor robustness.I also did a little fix in
InGameUI::getSuperweaponDisplayEnabledByScriptbut it is inconsequential because that function is never called.Camera is stuck spinning in Shell Map
generalszh.2025-09-18.20-18-52-67.mp4
TODO