bugfix(module): Fix damage calculation for determining the initial death of GLA Battle Bus #1603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ining initial death
xezon
reviewed
Sep 20, 2025
|
|
||
| if( damageInfo->in.m_damageType != DAMAGE_UNRESISTABLE | ||
| && !m_isSecondLife | ||
| #if RETAIL_COMPATIBLE_CRC |
There was a problem hiding this comment.
I think better use RETAIL_COMPATIBLE_BUG here
Author
There was a problem hiding this comment.
As in this is a desirable bug to be kept? If some players strangely desire this behaviour, they can surely just tweak the Battle Bus's HAZARD_CLEANUP damage modifier to deal damage.
Armor BattleBusTruckArmor
+ Armor = HAZARD_CLEANUP 50% ;Now consistently harmed by cleaning weapons
- Armor = HAZARD_CLEANUP 0% ;Not harmed by cleaning weapons
End
xezon
approved these changes
Sep 21, 2025
xezon
changed the title
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
…ath of GLA Battle Bus (TheSuperHackers#1603)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #135
This change fixes the damage calculation for determining the Battle Bus's initial death, meaning it no longer prematurely dies when receiving damage via radiation or poison fields.
The issue is most notable when receiving damage via radiation or poison fields due to
HazardFieldCoreWeapon- an invisible 200-damage hazard cleanup weapon that typically accompanies poison and radiation fields to stop them from stacking. As no armour damage modifiers are applied to ignore the hazard cleanup damage, the Battle Bus dies when receiving damage from this source if health is <= 200. Even an Ambulance can kill a Battle Bus by exploiting this logic.GOOD_BUS.mp4