bugfix(input): Fix broken single click command after right mouse double click #1605
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is an alternative fix to #1454 and fixes single right-click behavior not being performed on a double right-click.
What happens is that
MSG_RAW_MOUSE_RIGHT_DOUBLE_CLICKimplictly is aMSG_RAW_MOUSE_RIGHT_BUTTON_DOWNmessage, but it is not handled the same way asMSG_RAW_MOUSE_RIGHT_BUTTON_DOWNand therefore loses the mouse click timing inCommandTranslator.MSG_RAW_MOUSE_RIGHT_BUTTON_UPis always sent on both single and double click and therefore requires no special attention.Repro Steps
TODO