refactor(tree): Simplify W3DTreeDraw related code #1614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Minor
xezon
force-pushed
the
xezon/refactor-tree-draw
branch
from
463b613 to
f74a163
Compare
Author
|
For Zero Hour only. Not replicated in Generals. |
Author
|
But the bridge refactor side quest can be replicated in Generals. |
1 task
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies W3DTreeDraw related code a bit.
It took me a while to understand what is going on. With the new code changes it is a bit clearer, plus it gets rid of the
setOrientation(),setPosition()call order dependency. Originally the functions had the be called in this order for the tree register to work correctly, now it no longer matters.User facing nothing should change.
TODO