bugfix(network): Fix clearing remote player commands in Connection::clearCommandsExceptFrom() to prevent local player left hanging in game over screen #1638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this fix #206 ? |
i could look at testing this with some people to see if it makes a difference when integrated |
|
Stubbjax did write
It is not clear if this refers to #206 |
Author
I believe it covers some cases but not all of them. |
xezon
changed the title
xezon
changed the title
|
It appears to help speedup transitioning to the score screen when a game ends normally and the victory or defeat windows shows. One thing it doesn't seem to help is if someone surrenders then quits straight away, the other player can get stuck on the victory screen for an extended period. |
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
…learCommandsExceptFrom() to prevent local player left hanging in game over screen (TheSuperHackers#1638)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue where only a single network command is cleared per connection upon leaving a game, rather than the entire list as expected. This occurs due to the command list iterator being invalidated when removing the current node.
This resolves cases where players are not immediately sent to the score screen after leaving a game due to network commands being left in the buffer.