bugfix(network): Fix Network stalling state #1650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Bug
Mauller
approved these changes
Sep 30, 2025
xezon
force-pushed
the
xezon/rendering-1-network-stalling
branch
from
8b01517 to
12fd38a
Compare
Author
|
Replicated in Generals without conflicts. |
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a follow up for #1528 and fixes the issue where tint color (and probably other visuals) did not work in Network matches at 30 render fps.
It happened because the Client update happens before Network update, and therefore the
isStallingfunction always returned true (at 30 fps) and the client update skipped certain updates because it would think that the Network was stalling when it was not.To fix this, we now detect the stalling state in the Network update function and save it for each frame.
TODO