Skip to content

Conversation

@xezon
Copy link

@xezon xezon commented Sep 29, 2025

This change decouples the tint update step from the render update.

TODO

  • Replicate in Generals

@xezon xezon added Enhancement Is new feature or request Minor Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour Rendering Is Rendering related labels Sep 29, 2025
@xezon xezon added this to the Decouple logic and rendering milestone Sep 29, 2025
Copy link

@Skyaero42 Skyaero42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@xezon xezon force-pushed the xezon/rendering-2-tint-update branch from b532214 to 2876aa1 Compare October 7, 2025 16:02
@xezon
Copy link
Author

xezon commented Oct 7, 2025

Replicated in Generals without conflicts

D:\Projects\TheSuperHackers\GeneralsGameCode>FOR /F "delims=" %b IN ('git merge-base --fork-point main') DO git diff %b  1>changes.patch

D:\Projects\TheSuperHackers\GeneralsGameCode>git diff 16ff7e43b950fc27fb9b37ad3d7b96a54a7eb98b  1>changes.patch

D:\Projects\TheSuperHackers\GeneralsGameCode>git apply -p2 --directory=Generals --reject --whitespace=fix changes.patch
changes.patch:35: trailing whitespace.
                        if (decayRate.Length() > m_currentColor.Length() || m_currentColor.Length() <= FADE_RATE_EPSILON)
Checking patch Generals/Code/GameEngine/Include/GameClient/Drawable.h...
Hunk #1 succeeded at 203 (offset -3 lines).
Checking patch Generals/Code/GameEngine/Source/GameClient/Drawable.cpp...
Hunk #1 succeeded at 4784 (offset -757 lines).
Hunk #2 succeeded at 4797 (offset -757 lines).
Hunk #3 succeeded at 4830 (offset -757 lines).
Hunk #4 succeeded at 4842 (offset -757 lines).
Hunk #5 succeeded at 4876 (offset -757 lines).
Hunk #6 succeeded at 4897 (offset -757 lines).
Applied patch Generals/Code/GameEngine/Include/GameClient/Drawable.h cleanly.
Applied patch Generals/Code/GameEngine/Source/GameClient/Drawable.cpp cleanly.
warning: 1 line applied after fixing whitespace errors.

@xezon xezon merged commit 341bef2 into TheSuperHackers:main Oct 7, 2025
18 checks passed
@xezon xezon deleted the xezon/rendering-2-tint-update branch October 7, 2025 16:20
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Is new feature or request Gen Relates to Generals Minor Severity: Minor < Major < Critical < Blocker Rendering Is Rendering related ZH Relates to Zero Hour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Selection flash is improperly scaled by frame rate

2 participants