Skip to content

tweak(tree): Decouple tree sway, topple and sink time step from render update #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 15, 2025
Merged

tweak(tree): Decouple tree sway, topple and sink time step from render update #1652

merged 4 commits into from
Oct 15, 2025

Conversation

@xezon
Copy link

@xezon xezon commented Sep 29, 2025 •
edited
Loading

This change decouples tree sway, topple and sink time step from render update.

Note that there are 2 kinds of trees:

  • Optimized: using W3DTreeBuffer
  • Unoptimized: using Object with logic modules, for example Palm Trees

Only optimized trees will enjoy full decoupling.

The unoptimized trees use the following modules:

  • SwayClientUpdate: for client swaying
  • ToppleUpdate: for logic topple
  • SlowDeathBehavior: for logic death

We cannot decouple ToppleUpdate and SlowDeathBehavior from logic.

TODO

  • Replicate in Generals

@xezon xezon added Enhancement Is new feature or request Minor Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour Rendering Is Rendering related labels Sep 29, 2025
@xezon xezon added this to the Decouple logic and rendering milestone Sep 29, 2025
@xezon xezon force-pushed the xezon/rendering-3-tree-updates branch from 38d536d to 4e24452 Compare October 6, 2025 20:39
@xezon xezon force-pushed the xezon/rendering-3-tree-updates branch from 4e24452 to 25727a1 Compare October 14, 2025 17:20
@xezon
Copy link
Author

xezon commented Oct 14, 2025

Updated.

Skyaero42
Skyaero42 previously approved these changes Oct 14, 2025
View reviewed changes
Copy link

@Skyaero42 Skyaero42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@Skyaero42 Skyaero42 dismissed their stale review October 14, 2025 18:01

Want to test first

Skyaero42
Skyaero42 approved these changes Oct 15, 2025
View reviewed changes
Copy link

@Skyaero42 Skyaero42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trees seem to sway correctly

@xezon xezon force-pushed the xezon/rendering-3-tree-updates branch from 25727a1 to 210e8f9 Compare October 15, 2025 20:29
@xezon
Copy link
Author

xezon commented Oct 15, 2025

Replicated SwayClientUpdate in Generals without conflicts.

Things in W3DTreeBuffer not replicated because Generals version of it is old.

@xezon xezon merged commit 9ba92fa into TheSuperHackers:main Oct 15, 2025
18 checks passed
@xezon xezon deleted the xezon/rendering-3-tree-updates branch October 15, 2025 20:56
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Nov 10, 2025
@xezon
tweak(tree): Decouple tree sway, topple and sink time step from rende…
861f66d 
…r update (TheSuperHackers#1652)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mauller Mauller Mauller left review comments

@Skyaero42 Skyaero42 Skyaero42 approved these changes

Assignees

No one assigned

Labels

Enhancement Is new feature or request Gen Relates to Generals Minor Severity: Minor < Major < Critical < Blocker Rendering Is Rendering related ZH Relates to Zero Hour

Projects

None yet

Milestone

Decouple logic and rendering

Development

Successfully merging this pull request may close these issues.

Trees sway too fast

3 participants

@xezon @Skyaero42 @Mauller