tweak(fps): Simplify function W3DDisplay::updateAverageFPS() and remove its frame spike filter #1662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mauller
approved these changes
Oct 7, 2025
Mauller
left a comment
Mauller
left a comment
There was a problem hiding this comment.
Looks good to me, this code always looked broken when i first noticed it.
xezon
force-pushed
the
xezon/improve-average-fps-impl
branch
from
a6eb561 to
9085d6a
Compare
Author
|
Replicated in Generals without conflicts. |
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
…ve its frame spike filter (TheSuperHackers#1662)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the Munkee übercomplexity and the frame spike filter from W3DDisplay::updateAverageFPS().
The spike filter ignored any frames longer than 500 ms and that does not make sense to keep around.
TODO