tweak(module): Add 'TransferSelection' field to CreateObjectDie INI module to allow transfer selection on object creation #1665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stubbjax
added
Bug
xezon
reviewed
Oct 6, 2025
xezon
left a comment
xezon
left a comment
There was a problem hiding this comment.
Feature or bugfix?
Is half bugfix, half feature. Given that this is mainly undesired behavior with the Sneak Attack, I would say we can label it bugfix.
Generals also has this Module. Replicate the change there?
GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Die/CreateObjectDie.cpp
Outdated
Show resolved
Hide resolved
GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Die/CreateObjectDie.cpp
Show resolved
Hide resolved
Author
I was going to, but was stopped by |
|
Can be separate change, replicating these fields to Generals. |
xezon
approved these changes
Oct 7, 2025
xezon
changed the title
xezon
changed the title
xezon
changed the title
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
…odule to allow transfer selection on object creation (TheSuperHackers#1665) This change allows to configure the GLA Sneak Attack in INI to remain selected after it transitioned to the fully emerged object. Object GLASneakAttackTunnelNetworkStart Behavior = CreateObjectDie ModuleTag ... TransferSelection = Yes ; The tunnel remains selected after emerging End End
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the Sneak Attack to remain selected when it transitions from its spawning object.
A new
TransferSelectionfield can now be added to theCreateObjectDiemodule to enable this behaviour.Note: No other object uses the
TransferPreviousHealthfield, so this field could technically be used to control the reselection behaviour (initially?) and thus be retail compatible. However, it would not make logical sense and would confound the behaviour.Object GLASneakAttackTunnelNetworkStart Behavior = CreateObjectDie ModuleTag_11 CreationList = OCL_CreateSneakAttackTunnel TransferPreviousHealth = Yes + TransferSelection = Yes End EndFeature or bugfix?