fix: Replace wcsncpy with wcslcpy for robustness #1676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skyaero42
commented
Oct 7, 2025
11 tasks
xezon
added
Minor
xezon
changed the title
xezon
reviewed
Oct 12, 2025
xezon
left a comment
xezon
left a comment
There was a problem hiding this comment.
There is at least 1 error.
Might want to think about using ARRAY_SIZE more for robustness, maybe in a follow up change if better suited.
GeneralsMD/Code/GameEngine/Source/GameNetwork/LANAPIhandlers.cpp
Outdated
Show resolved
Hide resolved
xezon
changed the title
Skyaero42
force-pushed
the
refactor/wstrncpy
branch
from
fee7656 to
50ad6c4
Compare
Skyaero42
force-pushed
the
refactor/wstrncpy
branch
from
50ad6c4 to
28a7e0b
Compare
Author
|
Changed to ARRAY_SIZE() |
xezon
approved these changes
Oct 15, 2025
|
Needs replicating. |
Author
|
Replicated in Generals |
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces wstrncpy with wstrlcpy for robustness
TODO