Skip to content

fix: Replace strncat with strlcat for robustness #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2025
Merged

fix: Replace strncat with strlcat for robustness #1677

merged 1 commit into from
Oct 15, 2025

Conversation

@Skyaero42
Copy link

@Skyaero42 Skyaero42 commented Oct 7, 2025

This change replaces strncat with strlcat for robustness

@Skyaero42 Skyaero42 added this to the Code foundation build up milestone Oct 7, 2025
@Skyaero42 Skyaero42 self-assigned this Oct 7, 2025
@Skyaero42 Skyaero42 added the Stability Concerns stability of the runtime label Oct 7, 2025
@Skyaero42 Skyaero42 mentioned this pull request Oct 7, 2025
Open
11 tasks
@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Refactor Edits the code with insignificant behavior changes, is never user facing labels Oct 12, 2025
@xezon xezon changed the title fix: replace strncat with strlcat for robustness fix: Replace strncat with strlcat for robustness Oct 12, 2025
xezon
xezon approved these changes Oct 12, 2025
View reviewed changes
Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough

@xezon
Copy link

xezon commented Oct 15, 2025

Needs rebasing.

@Skyaero42
Copy link
Author

Skyaero42 commented Oct 15, 2025

Needs rebasing.

Done

@xezon xezon merged commit 9e4b82f into TheSuperHackers:main Oct 15, 2025
17 checks passed
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Nov 10, 2025
@Skyaero42
fix: Replace strncat with strlcat for robustness (TheSuperHackers#1677)
b982191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xezon xezon xezon approved these changes

Assignees

@Skyaero42 Skyaero42

Labels

Minor Severity: Minor < Major < Critical < Blocker Refactor Edits the code with insignificant behavior changes, is never user facing Stability Concerns stability of the runtime

Projects

None yet

Milestone

Stability fixes

Development

Successfully merging this pull request may close these issues.

2 participants

@Skyaero42 @xezon