Skip to content

Conversation

@xezon
Copy link

@xezon xezon commented Oct 8, 2025

This change moves STLUtils.h to WWLib so that the stl helpers can be used in Vegas code too.

When moving, there was a wild VC6 compile error:

D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\Libraries\Source\WWVegas\WW3D2\dazzle.cpp(1501) : fatal error C1001: INTERNAL COMPILER ERROR
(compiler file 'msc1.cpp', line 1794)
Please choose the Technical Support command on the Visual C++
Help menu, or open the Technical Support help file for more information

To avoid this mayhem, the count variables had to be touched in some way.

@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Refactor Edits the code with insignificant behavior changes, is never user facing labels Oct 8, 2025
@xezon
Copy link
Author

xezon commented Oct 8, 2025

Still fails ... edit: forgot Generals. Should work now.

Copy link

@Skyaero42 Skyaero42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good,

Due to the count change, there will be (possibly) one more debug message (10 instead of 9) than before if files can't be found, but that is acceptable.

@xezon xezon merged commit fbb1ca4 into TheSuperHackers:main Oct 9, 2025
17 checks passed
@xezon xezon deleted the xezon/move-stlutils-to-wwlib branch October 9, 2025 18:55
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Minor Severity: Minor < Major < Critical < Blocker Refactor Edits the code with insignificant behavior changes, is never user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants