tweak(shadow): Double 3D shadow buffers in W3DBufferManager

[xezon]

This change doubles the 3D shadow buffers. Shadows are not cheap.

It also rearranges and comments the constants for ease of read.

Original Investigation

The original investigation was done in TheAssemblyArmada/Thyme#604

We know that 512 + 1 Scorpion Tanks in the scene will deplete the shadow memory pools.

I tested against 1024 Scorpion Tanks in the scene.

Double MAX_NUMBER_SLOTS only with 1024 Scorpion Tanks

        MAX_NUMBER_SLOTS = 4096 * 2
        MAX_VERTEX_BUFFERS_CREATED = 32
        MAX_INDEX_BUFFERS_CREATED = 32
        MAX_VB_SIZES = 128
        MAX_IB_SIZES = 128

results in

-		g_theW3DBufferManager
		m_numEmptyVertexSlotsAllocated	4318	int
		m_numEmptyVertexBuffersAllocated	32	int
		m_numEmptyIndexSlotsAllocated	4323	int
		m_numEmptyIndexBuffersAllocated	22	int

m_numEmptyVertexBuffersAllocated now caps out at 32 and it cannot draw shadows for all meshes. m_numEmptyVertexSlotsAllocated should cap out at 8192.

Double MAX_NUMBER_SLOTS and BUFFERS_CREATED with 1024 Scorpion Tanks

        MAX_NUMBER_SLOTS = 4096 * 2
        MAX_VERTEX_BUFFERS_CREATED = 32 * 2
        MAX_INDEX_BUFFERS_CREATED = 32 * 2
        MAX_VB_SIZES = 128
        MAX_IB_SIZES = 128

results in

-		g_theW3DBufferManager
		m_numEmptyVertexSlotsAllocated	8192	int
		m_numEmptyVertexBuffersAllocated	62	int
		m_numEmptyIndexSlotsAllocated	8192	int
		m_numEmptyIndexBuffersAllocated	41	int

m_numEmptyVertexSlotsAllocated now caps out at 8192 and all meshes cast shadows in the scene

Conclusion

Scaling the following 3 limits uniformly is the correct strategy.

MAX_NUMBER_SLOTS
MAX_VERTEX_BUFFERS_CREATED
MAX_INDEX_BUFFERS_CREATED

TODO

• Replicate in Generals

[Skyaero42]

The one million dollar question: why double and not triple? I can fit more scorpions on that screen.

[xezon]

Replicated in Generals without conflicts