tweak(lan): Hide computer identity in LAN lobby #1693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this also stop your machine sending your information? |
Author
|
Yes |
|
What is now shown instead? |
Author
|
When user does not tell its identity, then no tooltip is shown. |
xezon
force-pushed
the
xezon/hide-computer-identity-lan
branch
from
54246df to
3122356
Compare
Author
|
Replicated in Generals without conflicts. |
xezon
added a commit
that referenced
this pull request
Oct 15, 2025
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with Rebase
This change hides the computer identity in the LAN lobby. Originally it would expose the User login name and Computer name. Generally in pure Local Network matches this would be alright, but the Network Lobby is used for virtual private networks such as GameRanger and Radmin where we meet wild Internet users and generally want to keep our privacy.
The UI will still show computer information from retail game clients.
The identity was shown in this format:
loginname@COMPUTER_NAMETODO