Skip to content

bugfix(scene): Fix translucent objects drawn without translucency when no occluders are in the scene #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2025
Merged

bugfix(scene): Fix translucent objects drawn without translucency when no occluders are in the scene #1710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a54e1d
bugfix(scene): Fix translucent objects drawn without translucency whe…
xezon Oct 18, 2025
34acc85
refactor(scene): Clean formatting, comments in W3DScene (#1710)
xezon Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 11 additions & 16 deletions Generals/Code/GameEngineDevice/Include/W3DDevice/GameClient/W3DScene.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
#include "WW3D2/rinfo.h"
#include "WW3D2/coltest.h"
#include "WW3D2/lightenvironment.h"

///////////////////////////////////////////////////////////////////////////////
// PROTOTYPES /////////////////////////////////////////////////////////////////
///////////////////////////////////////////////////////////////////////////////
Expand All @@ -64,7 +65,7 @@ class RTS3DScene : public SimpleSceneClass, public SubsystemInterface
public:

RTS3DScene(); ///< RTSScene constructor
~RTS3DScene(); ///< RTSScene desctructor
~RTS3DScene(); ///< RTSScene destructor

/// ray picking against objects in scene
Bool castRay(RayCollisionTestClass & raytest, Bool testAll, Int collisionType);
Expand All @@ -85,13 +86,13 @@ class RTS3DScene : public SimpleSceneClass, public SubsystemInterface
void renderSpecificDrawables(RenderInfoClass &rinfo, Int numDrawables, Drawable **theDrawables) ;

/// Lighting methods
void addDynamicLight(W3DDynamicLight * obj);
void removeDynamicLight(W3DDynamicLight * obj);
RefRenderObjListIterator * createLightsIterator(void);
void destroyLightsIterator(RefRenderObjListIterator * it);
RefRenderObjListClass *getDynamicLights(void) {return &m_dynamicLightList;};
void addDynamicLight(W3DDynamicLight * obj);
void removeDynamicLight(W3DDynamicLight * obj);
RefRenderObjListIterator *createLightsIterator(void);
void destroyLightsIterator(RefRenderObjListIterator * it);
RefRenderObjListClass *getDynamicLights(void) {return &m_dynamicLightList;};
W3DDynamicLight *getADynamicLight(void);
void setGlobalLight(LightClass *pLight,Int lightIndex=0);
void setGlobalLight(LightClass *pLight,Int lightIndex=0);
LightEnvironmentClass &getDefaultLightEnv(void) {return m_defaultLightEnv;}

void init() {}
Expand All @@ -101,8 +102,8 @@ class RTS3DScene : public SimpleSceneClass, public SubsystemInterface
void doRender(CameraClass * cam);

protected:
void renderOneObject(RenderInfoClass &rinfo, RenderObjClass *robj, Int localPlayerIndex);
void updateFixedLightEnvironments(RenderInfoClass & rinfo);
void renderOneObject(RenderInfoClass &rinfo, RenderObjClass *robj, Int localPlayerIndex);
void updateFixedLightEnvironments(RenderInfoClass & rinfo);
void flushTranslucentObjects(RenderInfoClass & rinfo);
void flushOccludedObjects(RenderInfoClass & rinfo);
void flagOccludedObjects(CameraClass * camera);
Expand Down Expand Up @@ -147,7 +148,6 @@ class RTS3DScene : public SimpleSceneClass, public SubsystemInterface
//-----------------------------------------------------------------------------
class RTS2DScene : public SimpleSceneClass, public SubsystemInterface
{

public:

RTS2DScene();
Expand All @@ -162,9 +162,9 @@ class RTS2DScene : public SimpleSceneClass, public SubsystemInterface
void doRender(CameraClass * cam);

protected:

RenderObjClass *m_status;
CameraClass *m_camera;

};

//-----------------------------------------------------------------------------
Expand All @@ -173,19 +173,14 @@ class RTS2DScene : public SimpleSceneClass, public SubsystemInterface
/** Scene management for 3D interface overlay on top of 3D scene */
//-----------------------------------------------------------------------------
class RTS3DInterfaceScene : public SimpleSceneClass

{

public:

RTS3DInterfaceScene();
~RTS3DInterfaceScene();

/// customizable renderer for the RTS3DInterfaceScene
virtual void Customized_Render( RenderInfoClass &rinfo );

protected:

};

#endif // end __W3DSCENE_H_
Loading
Loading