Skip to content

fix: Revert strlcat on pointer arguments #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2025
Merged

fix: Revert strlcat on pointer arguments #1713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Core/Libraries/Source/debug/debug_debug.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ bool Debug::AssertDone(void)
"time being (stops logging this assertion as well).";
char *help=(char *)DebugAllocMemory(ioBuffer[curType].used+strlen(addInfo)+1);
strcpy(help,ioBuffer[curType].buffer+82);
strlcat(help, addInfo, ARRAY_SIZE(help));
strcat(help, addInfo);

// First hit? Then do a stack trace
if (curFrameEntry->hits==1)
Expand Down Expand Up @@ -612,7 +612,7 @@ bool Debug::CrashDone(bool die)
#endif
char *help=(char *)DebugAllocMemory(ioBuffer[curType].used+strlen(addInfo)+1);
strcpy(help,ioBuffer[curType].buffer+82);
strlcat(help, addInfo, ARRAY_SIZE(help));
strcat(help, addInfo);

// First hit? Then do a stack trace
if (curFrameEntry->hits==1)
Expand Down
Loading