-
Notifications
You must be signed in to change notification settings - Fork 117
refactor: Replace all header include guards with pragma once #1722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace all header include guards with pragma once #1722
Conversation
|
Nice. It looks like some are missing. For example Before merging this change, we need another change first that removes all to |
|
Moving to draft to tackle |
|
This change can continue now. |
|
Working on it :) |
d1c75bb to
d630325
Compare
|
Ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file contains:
#ifndef _BASE_TYPE_H_
#include <Lib/BaseType.h>
#endif|
|
||
| #ifndef HLOD_H | ||
| #define HLOD_H | ||
|
|
||
| #ifndef ANIMOBJ_H |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still things to clean in this file.
Also in
- curve.h
- uarray.h
- colmath.h
- registry.h
- ...
and many more. I think you need to audit WW headers and remove all #ifndef around includes.
Or do you want to do that in a follow up change?
xezon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change cannot be merged as is with Rebasing, because it contains commits that do not compile on their own.
Will be merged with Squash, unless individual commits are fixed for Rebasing.
|
Let's squash merge this. I'll pick up the other |
Automatically strip #ifndef/#define pairs and matching #endif that follow #pragma once in header files. Cleans up legacy patterns left from mixed guarding styles.
In order of commits:
squash merge or rebase merge is both fine.