forked from electronicarts/CnC_Generals_Zero_Hour
-
Notifications
You must be signed in to change notification settings - Fork 117
build: Use more precompiled headers to reduce build time by around 50% #1740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
reviewed
Oct 25, 2025
774d1fe to
a25b6c9
Compare
Author
|
Rebased with review feedback changes included. |
xezon
approved these changes
Oct 27, 2025
xezon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice speed.
xezon
approved these changes
Oct 28, 2025
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved
Pull Request was approved
Build
Anything related to building, compiling
Enhancement
Is new feature or request
Major
Severity: Minor < Major < Critical < Blocker
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reduces the compile time of the solution by increasing the use of precompiled headers in various projects.
The prioritization of which headers to include was gained by referring to the Build Insights output of VS2022.
The following projects are changed:
The changes in Core/Libraries/debug and Core/Libraries/profile are a bit more involved than the other libraries, as the previous approach was to just include
_pch.h. These have now been changed to explicitly include the headers that are needed, validated by turning precompiled headers off and see that they still compile.Measuring the impact was done by compiling the presets vc6 and win32-debug with and without this change. 7 timing measurements was taken for each option and then averaged. The PowerShell snippet used to do this is:
The results were as follows