bugfix(filesystem): Tentatively fix hang in file exist cache #1751
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change tentatively fixes a hang in the file exist cache. It was observed when loading a map with a VS2022 build.
The logic was stuck in an infinite hash map lookup.
The theory is that 2 threads modified the
FileSystem::m_fileExistmap at the same time and corrupted its state.The callstack indicates that the texture loader thread was perhaps involved, which is one of the few multi threaded systems in the game process.
Perhaps it is a VS2022 specific issue. VC6 builds use a different hash map implementation.